There were (mostly) two kinds of warnings that I've handled, "80 character line length" and block comments structure. Some of the changes involve handling two separate warnings in a single comment. Where this occurs, should I break down the change into two steps - fixing a warning at a time? Or should I fix both warnings in the same commit - and place the commit in the most appropriate patch? thanks Moshe Green On 1 September 2016 at 19:04, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: >> Fix a line length warning found by the checkpatch.pl tool in >> ddk750_chip.c. >> >> Signed-off-by: Moshe Green <mgmoshes@xxxxxxxxx> >> --- >> drivers/staging/sm750fb/ddk750_chip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Lots of the patches in this series have the same exact subject: line, > yet they do different things. Please fix them up and make them more > obvious, or even better yet, merge them into less patches (one type of > thing per file per patch, not one single change per patch). > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
