On Thu, Jun 02, 2016 at 09:54:10AM +0530, Binoy Jayan wrote: > The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it > should be written as one. Semaphores are going away in the future. > _enter_pwrlock was using down_interruptible(), so the lock could be broken > by sending a signal. This could be a bug, because nothing checks the return > code here. Hence, using mutex_lock instead of the interruptible version. > Removing the now unused _enter_pwrlock and _down_sema. > > Signed-off-by: Binoy Jayan <binoy.jayan@xxxxxxxxxx> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > Tested-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > --- > This patch depends on the following patch: > rtl8712: intf_priv: Replace semaphore lock with completion This one patch doesn't apply to my tree for some odd reason. Can you rebase it on my staging-testing branch and resend it? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
