On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote: > On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote: > > The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source. > > I cannot promise the code style (although I did indent -kr -i8). > > I cannot also promise the effect. > > I don't understand this at all, sorry. > > Why should we accept this driver? Who is going to maintain it? What > needs to be done to it? > > And why are you top-posting? :) Dropping from my queue due to lack of a response. If you fix it up, please resend it, but we need the answers to the above questions if you do so. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel