This is how I think it should be fixed, but not tested yet. Subjec: netvsc: use device not module reference counts Fix how the cross-device reference counting is handled. When VF is associated with the synthetic interface, the VF driver module should still be able to be unloaded. The module unload code will callback with NETDEV_UNREGISTER event which breaks the connection safely. (Fixes 9f4b5ba5db4 hv_netvsc: Implement support for VF drivers on Hyper-V) Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxxxxxx> --- a/drivers/net/hyperv/netvsc_drv.c 2016-08-13 11:25:40.243995863 -0700 +++ b/drivers/net/hyperv/netvsc_drv.c 2016-08-13 11:25:40.239995844 -0700 @@ -1220,10 +1220,8 @@ static int netvsc_register_vf(struct net return NOTIFY_DONE; netdev_info(ndev, "VF registering: %s\n", vf_netdev->name); - /* - * Take a reference on the module. - */ - try_module_get(THIS_MODULE); + + dev_hold(vf_netdev); netvsc_dev->vf_netdev = vf_netdev; return NOTIFY_OK; } @@ -1345,7 +1343,7 @@ static int netvsc_unregister_vf(struct n netdev_info(ndev, "VF unregistering: %s\n", vf_netdev->name); netvsc_dev->vf_netdev = NULL; - module_put(THIS_MODULE); + dev_put(vf_netdev); return NOTIFY_OK; } _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
