From: Dexuan Cui <decui@xxxxxxxxxxxxx> Date: Sat, 23 Jul 2016 01:35:51 +0000 > +static struct sock *hvsock_create(struct net *net, struct socket *sock, > + gfp_t priority, unsigned short type) > +{ > + struct hvsock_sock *hvsk; > + struct sock *sk; > + > + sk = sk_alloc(net, AF_HYPERV, priority, &hvsock_proto, 0); > + if (!sk) > + return NULL; ... > + /* Looks stream-based socket doesn't need this. */ > + sk->sk_backlog_rcv = NULL; > + > + sk->sk_state = 0; > + sock_reset_flag(sk, SOCK_DONE); All of these are unnecessary initializations, since sk_alloc() zeroes out the 'sk' object for you. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel