On Jul 23, 2016, at 1:31 PM, Joe Perches wrote: > On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: >> From: Emoly Liu <emoly.liu@xxxxxxxxx> > > unrelated trivial notes: > >> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h > [] >> @@ -33,9 +33,9 @@ >> >> /* The persistent object (i.e. actually stores stuff!) */ >> #define ECHO_PERSISTENT_OBJID 1ULL >> -#define ECHO_PERSISTENT_SIZE ((__u64)(1<<20)) >> +#define ECHO_PERSISTENT_SIZE ((__u64)(1 << 20)) > > This is generally an error-prone pattern as the cast is > done after the shift. Hm, indeed. > Perhaps better is using a specific type > > #define ECHO_PERSISTENT_SIZE (1ULL << 20) Yes, I guess this is a better way. > And lustre seems to use types with unnecessary __ prefixes. Need to see if this file is included in userspace where the __ is needed. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
