On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote: > Each of these blocks will start with the dev_<level> prefix > and the subsequent lines will not have the same prefix Yes. I have checked how it looks before submitting, but I didn't see this as a problem. I don't mind changing that (anyway I have found few micro-issues with checkpatch --strict and would like to resubmit), but would like to hear some second opinion. > It also might be better to issue something like a single > line dev_warn referring to the driver code and just leave > this comment in the driver sources. > > Something like: > > dev_warn(&pci_dev->dev, > "This driver has known defects in video quality\n"); Things get complicated if you consider mainstream distros and their years-behind kernels. The simplest way to preserve correspondence between state of driver and such notice is to contain the notice in the compiled driver. I hope the state of affairs will change to better someday :) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
