On Thu, Jun 30, Dexuan Cui wrote:
> +/* The MTU is 16KB per the host side's design. */
> +struct hvsock_recv_buf {
> + unsigned int data_len;
> + unsigned int data_offset;
> +
> + struct vmpipe_proto_header hdr;
> + u8 buf[PAGE_SIZE * 4];
Please use some macro related to the protocol rather than a Linux
compiletime macro.
> +/* We send at most 4KB payload per VMBus packet. */
> +struct hvsock_send_buf {
> + struct vmpipe_proto_header hdr;
> + u8 buf[PAGE_SIZE];
Same here.
> + * Copyright(c) 2016, Microsoft Corporation. All rights reserved.
Here the BSD license follows. I think its required/desired to also
include a GPL blurb like it is done in many other files:
...
* Alternatively, this software may be distributed under the terms of
* the GNU General Public License ("GPL") version 2 as published by the
* Free Software Foundation.
....
Otherwise the MODULE_LICENSE string might be incorrect.
> + /* Hyper-V Sockets requires at least VMBus 4.0 */
> + if ((vmbus_proto_version >> 16) < 4) {
> + pr_err("failed to load: VMBus 4 or later is required\n");
I guess this mens WS 2016+, and loading in earlier host versions will
trigger this path? I think a silent ENODEV is enough.
> + return -ENODEV;
Olaf
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
