> From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Thursday, June 30, 2016 20:45 > To: Dexuan Cui <decui@xxxxxxxxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; > apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; vkuznets@xxxxxxxxxx; > cavery@xxxxxxxxxx; KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang > <haiyangz@xxxxxxxxxxxxx>; joe@xxxxxxxxxxx; rolf.neugebauer@xxxxxxxxxx > Subject: Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets > > From: Dexuan Cui <decui@xxxxxxxxxxxxx> > Date: Wed, 29 Jun 2016 11:30:40 +0000 > > > @@ -1509,4 +1509,18 @@ static inline void commit_rd_index(struct > vmbus_channel *channel) > > } > > > > > > +struct vmpipe_proto_header { > > + u32 pkt_type; > > It is wasteful to have two empty lines before this structure definition, one > is sufficient. > > ... Hi David, Thank you for pointing out the issues! I'll fix all of them, and check all the similar issues in the patch. Will post a new version ASAP. Thanks, -- Dexuan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
