On Wednesday, June 22, 2016 2:34:33 PM CEST Arnd Bergmann wrote:
> A change to the usb gadget core allowed certain API functions to be
> part of a loadable module, which breaks having emxx_udc built-in:
>
> drivers/staging/built-in.o: In function `nbu2ss_drv_probe':
> (.text+0x2428): undefined reference to `usb_ep_set_maxpacket_limit'
>
> The original patch already fixed tons of other cases that have the
> added dependency but apparently missed this one that now appears
> in an ARM allmodconfig build.
>
> This patch makes the symbol "tristate", which lets the Kconfig
> dependency tracking handle it correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core")
> ---
> drivers/staging/emxx_udc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/Kconfig b/drivers/staging/emxx_udc/Kconfig
> index cc3402020487..d7577096fb25 100644
> --- a/drivers/staging/emxx_udc/Kconfig
> +++ b/drivers/staging/emxx_udc/Kconfig
> @@ -1,5 +1,5 @@
> config USB_EMXX
> - bool "EMXX USB Function Device Controller"
> + tristate "EMXX USB Function Device Controller"
> depends on USB_GADGET && (ARCH_SHMOBILE || (ARM && COMPILE_TEST))
> help
> The Emma Mobile series of SoCs from Renesas Electronics and
>
I ran into another build error in some configrations, please disregard
this one and use v2 instead.
Arnd
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
