On 18/06/16 04:51, Greg KH wrote: > On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote: >> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: >>> This is a patch to the s626.c file that fixes up a line over 80 >>> characters issues found by the checkpatch.pl tool. >>> >>> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@xxxxxxxxx> >> >> Looks good :) >> >> This is the only instance of the line over 80 characters Warning in that file. >> >> Like previous patches, no need to mention the file being fixed in the commit >> message. It isn't a big deal though. >> >> +1 > > Not much I can do with at "+1", please respond with a: > Acked-by: > or even better: > Reviewed-by: > > with the proper info, so I can add it to the patch and give you credit > for reviewing it. > > thanks, > > greg k-h > Reviewed-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> Sorry, sometimes I am not sure if my comments warrant an Acked-by/Reviewed-by. Will always add one from now on. Thanks :) Luis _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel