On 13 June 2016 at 19:59, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Monday, June 13, 2016 4:07:32 PM CEST Binoy Jayan wrote: >> Hi, >> >> These are a set of patches which removes semaphores from: >> >> drivers/staging/wilc1000 >> >> These are part of a bigger effort to eliminate all semaphores >> from the linux kernel. >> >> They build correctly (individually and as a whole). >> >> NB: The changes are untested >> > > Most of these look really good, but I've commented on what I think > should be done differently, most importantly using a work_queue > rather than a completion to replace the semaphore in patch 6. > > Maybe you can resend the first five patches after addressing > my comments so we can get those tested and queued already while > you look into reworking patch 6. Let me know if that one ends up > being more complicated than I thought so we can come up with > a different approach. > > Arnd Thank you for reviewing the patches thoroughly. I overlooked the problem with using completion directly. Thank you for pointing that out. As you have suggested, I'll rework on the first 5 patches and work on the last one. Binoy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
