No mate, that aint just cutting it. I tried putting it, maybe i’m doing something wrong? Regards, Parth > On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> wrote: > > On 08/06/16 12:58, Parth Sane wrote: >> I’m trying to fix line 224 but its simply not happening. Can you help me with this? >> Regards, >> Parth >>> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> wrote: >>> >>> On 08/06/16 12:37, Parth Sane wrote: >>>> >>>>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> wrote: >>>>> >>>>> On 08/06/16 12:27, Parth Sane wrote: >>>>>> Multiple parenthesis alignment warnings were thrown by checkpatch in ieee80211.c >>>>>> This patch effectively fixes that. >>>>>> >>>>>> Signed-off-by: Parth Sane <laerdevstudios@xxxxxxxxx> >>>>>> >>>>>> --- >>>>>> drivers/staging/rtl8712/ieee80211.c | 25 ++++++++++++------------- >>>>>> 1 file changed, 12 insertions(+), 13 deletions(-) >>>>> >>>>> Some of the lines you change are over 80 characters. You could fix those as well in >>>>> a second patch :) >>>>> >>>>> Thanks, >>>>> Luis >>>>> >>>> >>>> You’re right on that regard. Maybe once this is accepted I can come back to other warnings. I will submit other patches meanwhile. >>>> I seriously want to see this driver in the next release! >>>> Regards, >>>> Parth >>>> >>> >>> You can resend this patch and the one fixing the 80 char limit with the subject >>> prefix [RESEND PATCH v2 x/2]. >>> >>> AFAIK this driver is already in the release, check menuconfig under >>> "Device Drivers > Staging drivers > Realtek RTL8172" >>> >>> Thanks, >>> Luis >> > > Sure. > > You want something like this: > - if (memcmp((pbuf + 2), wpa_oui_type, sizeof(wpa_oui_type))) > + if (memcmp((pbuf + 2), wpa_oui_type, > + sizeof(wpa_oui_type))) > > You could check for references of how other parts of the code have solved it > by doing: > git grep memcpy * | grep -v ";" > > I hope that helps. > Luis > > > > Reviewed-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
