On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote: > On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > > > > This is a patch to the s626.c file that fixes up a type issues like > > i.e Prefer kernel type 'u8' over 'uint8_t' > > Prefer kernel type 'u16' over 'uint16_t' > > Prefer kernel type 'u32' over 'uint32_t' > > Prefer kernel type 's16' over 'int16_t' > > Prefer kernel type 's32' over 'int32_t' > > found by the checkpatch.pl tool. > > > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > > --- > > changes since v1: Rework > > --- > > drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++----------------- > > 1 file changed, 106 insertions(+), 106 deletions(-) > > > Thanks. It would have been nice if the checkpatch.pl tool detected > _all_ the instances of these types. As a result of this patch, s626.c > contains a mixture of the different integer type styles. I guess we can > fix that up later though. Seems trivial enough to do. There was a possible issue with converting int_t types that were used as uapi function arguments. checkpatch currently warns only about variable declarations and not function declarations. It doesn't convert casts either. Should it? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
