On Wed, May 25, 2016 at 11:15:53PM +0100, Luis de Bethencourt wrote: > On 20/05/16 19:04, Kevin McKinney wrote: > > This patchset will fix the below issues reported checkpatch.pl tool. > > > > Kevin McKinney (3): > > Staging: wlan-ng: fix Alignment should match open parenthesis. > > This patch fixes alignment of parenthesis found by checkpatch.pl > > tool. > > Staging: wlan-ng: fix unnecessary parentheses around interface-dev. > > This is a path to fix unnecessary parentheses around interface-dev > > found by checkpatch.pl tool. > > Staging: wlan-ng: fix comparison to NULL. This patch fixes > > comparison to NULL found by checkpatch.pl tool. > > > > drivers/staging/wlan-ng/prism2usb.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > Hi Kevin, > > You have the entire commit message as the subject. > > For example, if I apply the first patch it shows like this: > Staging: wlan-ng: fix Alignment should match open parenthesis. This patch fixes alignment of parenthesis found by checkpatch.pl tool. > > Signed-off-by: Kevin McKinney <klmckinney1@xxxxxxxxx> > > This breaks the commit message formatting [0] > Move the line starting with "This patch" down to two lines below. > > Not sure if they are hard rules but the subject line should be > not much longer than 50 characters. And then the body of the message > should be 72 characters wide, since git indents it. > > Check a bunch of random recent commits in the git log and you will > get a feel of the format. > > Thanks, > Luis Thanks for the feedback Luis. I knew something looked strange with this patchset. I will resend. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
