On 20/05/16 17:27, Daniel Lockyer wrote:
> Kernel code style is to prefer the former so add `int` to the method
> parameters.
>
> Signed-off-by: Daniel Lockyer <thisisdaniellockyer@xxxxxxxxx>
> ---
> drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index 6d361201..765cb2d 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -92,7 +92,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
> }
>
> /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> +static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
> {
> int data;
> struct pio2_card *card = gpiochip_get_data(chip);
> @@ -111,7 +111,7 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> }
>
> /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
> +static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned int offset, int value)
> {
> int data;
> struct pio2_card *card = gpiochip_get_data(chip);
>
Unfortunately this doesn't apply cleanly on the staging-testing branch [0]
AFAIK Greg pushes new staging patches onto this branch.
Please fix so it does apply cleanly, the patch idea looks good.
Thanks :)
Luis
[0] https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?h=staging-testing
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
