On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> <driver>_REG_<name> format. Personally I prefer the format to be >> <driver>_<name>_REG. That way a grep for <driver>_<name> will >> return both the register and bit uses. > > It makes it easier to distinguish the register offsets from the register > values, imho. I guess. It's just not as common in comedi right now and it does make grep'ing for all the register/bit uses a bit more cumbersome. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
