On 17/05/16 18:46, Hartley Sweeten wrote:
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:This series of patches to the daqboard2000 driver is mostly to fix the checkpatch.pl warnings. There is one warning remaining about one of the `udelay` calls with a parameter of 10 microseconds, but I decided to leave it alone, as converting it to `usleep_range` could increase firmware loading time. Patches 03 and 06 have checkpatch warnings themselves about CamelCase issues, but they are not "new" issues, and are resolved by the later patches in the series. 01) staging: comedi: daqboard2000: remove commented out code 02) staging: comedi: daqboard2000: use usual block comment style 03) staging: comedi: daqboard2000: CHECK: spaces preferred around that '*' 04) staging: comedi: daqboard2000: add blank line after struct declaration 05) staging: comedi: daqboard2000: rename serial EEPROM register macros 06) staging: comedi: daqboard2000: rename register offset macros 07) staging: comedi: daqboard2000: rename acquisition control register macros 08) staging: comedi: daqboard2000: rename acq status register macros 09) staging: comedi: daqboard2000: redo DAC control register macros 10) staging: comedi: daqboard2000: redo DAC status macros and fix busy 11) staging: comedi: daqboard2000: rename trigger control register macros 12) staging: comedi: daqboard2000: rename reference DACs register macros 13) staging: comedi: daqboard2000: rename CamelCase functions 14) staging: comedi: daqboard2000: prefer usleep_range() drivers/staging/comedi/drivers/daqboard2000.c | 376 +++++++++++++------------- 1 file changed, 188 insertions(+), 188 deletions(-)Ian, I had a couple comments on patches 1, 5, 6, and 14 but they are really just nitpicks. If you prefer to leave this series as-is: Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Okay, I'll post a new series soon, taking your suggestions into account, apart from your comments on patch 5, which I'll leave until I modify the driver further.
I'll edit in your `Reviewed-by` lines if that's okay by you, since the changes are just following your suggestions, and are pretty trivial. The least trivial change is changing patch 14 to change `udelay(10)` to `usleep_range(10, 20)` as you suggested. The other changes are just renaming macros and tagging on a couple of comments.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
