On 16/05/16 11:18, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the daqboard2000.c file that fixes up a issues found by the checkpatch.pl tool. Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@xxxxxxxxx> --- drivers/staging/comedi/drivers/daqboard2000.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c index a536a15..edd91a1 100644 --- a/drivers/staging/comedi/drivers/daqboard2000.c +++ b/drivers/staging/comedi/drivers/daqboard2000.c @@ -116,12 +116,12 @@ #define DAQBOARD2000_SUBSYSTEM_IDS4 0x0004 /* Daqboard/2000 - 4 Dacs */ /* Initialization bits for the Serial EEPROM Control Register */ -#define DAQBOARD2000_SECRProgPinHi 0x8001767e -#define DAQBOARD2000_SECRProgPinLo 0x8000767e -#define DAQBOARD2000_SECRLocalBusHi 0xc000767e -#define DAQBOARD2000_SECRLocalBusLo 0x8000767e -#define DAQBOARD2000_SECRReloadHi 0xa000767e -#define DAQBOARD2000_SECRReloadLo 0x8000767e +#define DAQBOARD2000_SECRPROGPINHI 0x8001767e +#define DAQBOARD2000_SECRPROGPINLO 0x8000767e +#define DAQBOARD2000_SECRLOCALBUSHI 0xc000767e +#define DAQBOARD2000_SECRLOCALBUSLO 0x8000767e +#define DAQBOARD2000_SECRRELOADHI 0xa000767e +#define DAQBOARD2000_SECRRELOADLO 0x8000767e /* SECR status bits */ #define DAQBOARD2000_EEPROM_PRESENT 0x10000000
This doesn't compile. Also, there are several other CamelCase issues in this driver, although probably too many to deal with in a single patch.
I'll have a shot at a slightly more extensive clean-up. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
