On Sun, May 01, 2016 at 06:05:31PM +0530, Muhammad Falak R Wani wrote: > It is safe to use RCU_INIT_POINTER() to NULL a pointer, instead of > rcu_assign_pointer(). > This results in slightly smaller/faster code. > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx> I'm fine with your commit message and don't need to resend, however the statements like "smaller code" need to be supported by ./scripts/bloat-o-meter and "faster code" by performance analysis. Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > --- > drivers/staging/rdma/hfi1/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rdma/hfi1/init.c b/drivers/staging/rdma/hfi1/init.c > index cfcdc16..34e0f90 100644 > --- a/drivers/staging/rdma/hfi1/init.c > +++ b/drivers/staging/rdma/hfi1/init.c > @@ -1303,7 +1303,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd) > > spin_lock(&ppd->cc_state_lock); > cc_state = get_cc_state(ppd); > - rcu_assign_pointer(ppd->cc_state, NULL); > + RCU_INIT_POINTER(ppd->cc_state, NULL); > spin_unlock(&ppd->cc_state_lock); > > if (cc_state) > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
