> -----Original Message----- > From: Romer, Benjamin M > Sent: Tuesday, February 16, 2016 10:03 AM > To: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; > Sell, Timothy C <Timothy.Sell@xxxxxxxxxx>; *S-Par-Maintainer > <SParMaintainer@xxxxxxxxxx> > Subject: Re: Time for a code audit? > ... > > Hi Dan, > > Thank you for this list! We'll get started on fixing these issues > immediately. I've run Smatch using the make options > > O=../builds/testbuild CC=gcc-4.9 CHECK="smatch -p=kernel" C=1 > > but when I use it this way, I don't get that line where it complains > about the variable's size. What settings do you use? > > If I can generate a list of problems that way across the whole driver > set, we can just resolve them all without having to bother you or Greg > until we have patches for them. > > Thanks a ton for the review. :) > > -- Ben Greg, With the patch "[PATCH] staging: unisys: visorbus: initialize variables", I believe all the issues brought up by both you and Dan are addressed by the patches you accepted. Also during the time we did some additional cleanup. What is the next step to get visorbus out of the staging directory? What do we do with the include files? Also, I'm working on removing the MODULE_ALIAS lines from visorinput, visornic, and visorhba. I believe this requires me to make changes in include/kernel/mod_devicemodules.h and scripts/mod/*. Should I send those fixes to the respective maintainers now or when we move the other drivers from staging? Thanks, David Kershner _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
