On Wednesday, April 13, 2016 5:37 AM, Ian Abbott wrote: > On 12/04/16 22:12, H Hartley Sweeten wrote: >> This "driver" is is bit of a mess. It's included by the ni_atmio, ni_mio_cs, >> and ni_pcimio drivers instead of being a separate module. >> >> Do some cleanup so I can work out what is needed to make it a module. >> >> This fixes all the checkpatch.pl issues except for two: >> CHECK: if this code is redundant consider removing it >> >> I left those in until I can figure out if they can be removed. >> >> H Hartley Sweeten (19): >> staging: comedi: ni_mio_common: remove some unnecessary BUG_ON() >> staging: comedi: ni_mio_common: tidy up mite dma channel requests >> staging: comedi: ni_mio_common: tidy up mite dma channel releases >> staging: comedi: ni_mio_common: tidy up DIO subdevice ifdef'ery >> staging: comedi: ni_mio_common: Prefer 'unsigned int' to bare use of 'unsigned' >> staging: comedi: ni_mio_common: use 'unsigned int' instead of kernel types >> staging: comedi: ni_mio_common: tidy up block comments >> staging: comedi: ni_mio_common: fix lines over 80 characters >> staging: comedi: ni_mio_common: multiple assignments should be avoided >> staging: comedi: ni_mio_common: fix logical continuations >> staging: comedi: ni_mio_common: convert NI_GPCT_SUBDEV to a macro >> staging: comedi: ni_mio_common: tidy up AO trigger selection >> staging: comedi: ni_mio_common: tidy up AO scan begin >> staging: comedi: ni_mio_common: tidy up ni_gpct_write_register() >> staging: comedi: ni_mio_common: usleep_range is preferred over udelay >> staging: comedi: ni_mio_common: remove 'fudge_factor_80_to_20Mhz' >> staging: comedi: ni_mio_common: fix CamelCase in ni_serial_hw_readwrite8() >> staging: comedi: mite.h: rename CHSR_LxERR_mask >> staging: comedi: ni_mio_common: introduce NI_STC_DMA_CHAN_SEL() >> >> drivers/staging/comedi/drivers/mite.h | 2 +- >> drivers/staging/comedi/drivers/ni_mio_common.c | 860 ++++++++++++------------- >> drivers/staging/comedi/drivers/ni_stc.h | 1 - >> 3 files changed, 402 insertions(+), 461 deletions(-) >> > > Thanks! Patch 04 needs a fix. The others look good. > > For patches 01-03, 05-19.... > Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> Thanks. I'll fix Patch 04 and repost. Greg, Do you want the whole series reposed as v2 or just an updated patch 04? > You can add my "Reviewed-by:" line to patch 04 after restoring the > devpriv->is_m_series test to handle_cdio_interrupt(). > > One possible strategy for ni_mio_common.c would be to copy it inline > into the the files that #include it, remove the redundant code from each > file, then look for common code that could be moved into a new module. That might be the best option. I have been trying to work t out another way and it's just a bit mess. I'll keep looking at it. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
