Re: [PATCH v2 00/37] staging: comedi: das1800: tidy up driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/04/16 20:41, H Hartley Sweeten wrote:
Tidy up this driver and fix all the checkpatch.pl issues.

This series applies after the bug fix series:
   [PATCH v2 0/3] staging: comedi: das1800: bug fixes

v2 changes:
   * refactor based on the bug fix series
   * reorder the series to tidy up das1800_probe() early and then
     use the board 'id' to set various subdevice info instead of
     adding additional bit-field flags to the boardinfo
   * leave the number of analog input channels as-is, at the request
     of Ian Abbott
   * clarify step 4 of the analog input (*do_cmdtest)
   * allow setting the external trigger polarity

H Hartley Sweeten (37):
   staging: comedi: das1800: tidy up digital output subdevice init
   staging: comedi: das1800: tidy up digital input subdevice init
   staging: comedi: das1800: tidy up analog output subdevice init
   staging: comedi: das1800: tidy up analog input subdevice init
   staging: comedi: das1800: tidy up boardinfo
   staging: comedi: das1800: tidy up das1800_probe()
   staging: comedi: das1800: remove 'common' boardinfo member
   staging: comedi: das1800: use comedi_offset_munge() for analog output
   staging: comedi: das1800: remove 'resolution' boardinfo
   staging: comedi: das1800: remove 'do_n_chan' boardinfo
   staging: comedi: das1800: initialize all analog outputs
   staging: comedi: das1800: tidy up das1800_ao_insn_write()
   staging: comedi: das1800: remove 'ao_n_chan' boardinfo
   staging: comedi: das1800: remove 'ao_ability' boardinfo
   staging: comedi: das1800: refactor 'range_ai' boardinfo
   staging: comedi: das1800: remove 'qram_len' boardinfo
   staging: comedi: das1800: change type of 'ai_speed' boardinfo
   staging: comedi: das1800: add analog output readback
   staging: comedi: das1800: introduce das1800_ai_chanspec_bits()
   staging: comedi: das1800: absorb control_c_bits()
   staging: comedi: das1800: refactor program_chanlist()
   staging: comedi: das1800: use comedi_timeout()
   staging: comedi: das1800: absorb control_a_bits()
   staging: comedi: das1800: document the spinlock
   staging: comedi: das1800: cleanup copyright and comedi comment blocks
   staging: comedi: das1800: change type of private data 'fifo_buf'
   staging: comedi: das1800: move comment about max conversion speeds
   staging: comedi: das1800: remove the private data member comments
   staging: comedi: das1800: clarify step 4 of the ai (*do_cmdtest)
   staging: comedi: das1800: remove the function comments
   staging: comedi: das1800: fix comments in das1800_ai_cmd()
   staging: comedi: das1800: fix comments in das1800_ai_handler()
   staging: comedi: das1800: fix lines over 80 characters
   staging: comedi: das1800: fix comments about the 'ao' board range
   staging: comedi: das1800: clarify the analog input cmd triggers
   staging: comedi: das1800: allow setting the external trigger polarity
   staging: comedi: das1800: update the MODULE_DESCRIPTION

  drivers/staging/comedi/drivers/das1800.c | 1305 ++++++++++++++----------------
  1 file changed, 614 insertions(+), 691 deletions(-)


Thanks!

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux