Re: [PATCH] staging: android: ion: make locally used functions static

[Laura Abbott <labbott@xxxxxxxxxx>]

On 04/06/2016 02:53 PM, Markus Böhme wrote:
> Functions ion_handle_put and ion_handle_get_by_id are only used locally
> in ion.c, so they should be made static as they used to be before
> 9590232b ("staging/android/ion : fix a race condition in the ion driver").
>
> Signed-off-by: Markus Böhme <markus.boehme@xxxxxxxxxxx>

Reviewed-by: Laura Abbott <labbott@xxxxxxxxxx>

> ---
>   drivers/staging/android/ion/ion.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index d4c6207..a2cf93b 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -396,7 +396,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle)
>   	return ret;
>   }
>
> -int ion_handle_put(struct ion_handle *handle)
> +static int ion_handle_put(struct ion_handle *handle)
>   {
>   	struct ion_client *client = handle->client;
>   	int ret;
> @@ -438,8 +438,8 @@ static struct ion_handle *ion_handle_get_by_id_nolock(struct ion_client *client,
>   	return handle ? handle : ERR_PTR(-EINVAL);
>   }
>
> -struct ion_handle *ion_handle_get_by_id(struct ion_client *client,
> -						int id)
> +static struct ion_handle *ion_handle_get_by_id(struct ion_client *client,
> +					       int id)
>   {
>   	struct ion_handle *handle;

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel