On Thu, Apr 07, 2016 at 06:49:58AM +0900, Tetsuo Handa wrote: > Dan Carpenter wrote: > > Hello Tetsuo Handa, > > Hello, Dan. > > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch 77ed2c5745d9: "android,lowmemorykiller: Don't abuse > > TIF_MEMDIE." from Mar 8, 2016, leads to the following Smatch > > complaint: > > > > drivers/staging/android/lowmemorykiller.c:145 lowmem_scan() > > error: we previously assumed 'p->mm' could be null (see line 134) > > This is a false positive. find_lock_task_mm() returns a task_struct > whose mm is not NULL (with alloc_lock spinlock held). Yeah. Smatch isn't supposed to warn about this. I'll look at it. But we should still remove the unneeded NULL check, right? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
