Re: KVP daemon/module race on module unloading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dexuan Cui <decui@xxxxxxxxxxxxx> writes:

> Hi Vitaly,
> We got the below warning once -- it's pretty hard to repro it.
>
> I think the cause may be: before the daemon is terminated, we can successfully
> "rmmod hv_utils" -- as a result all the code/data segments of the module
> shouldn't be accessed any more,  but in the kernel we still has a dangling
> pointer set up by hvt_op_poll() -> poll_wait(file, &hvt->outmsg_q, wait);
>
> Finally, when the daemon is terminated, the call trace could happen.
>
> I think the module should never be unloaded when there is a fd opened
> on /dev/vmbus/hv_kvp?

Yes, I was pretty sure .owner = THIS_MODULE does that.

There was a fix from Alex a month ago:

commit e66853b09017a788dc384dadce9323396dae3293
Author: Alex Ng <alexng@xxxxxxxxxxxxx>
Date:   Fri Feb 26 15:13:20 2016 -0800

    Drivers: hv: utils: Remove util transport handler from list if
    registration fails

Do you have it in your kernel? (though I think it only applies if
transport registration fails...)

I'll take a closer look anyway, thanks for the report!

-- 
  Vitaly
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux