Re: [PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2016-03-19 at 18:35 +0000, Parth Sane wrote:
> Fixed alignment of paranthesis as per checkpatch.

Please run your proposed patches through checkpatch.
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
>  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
>  		ndata1.phy_addr[mac] = mac + 4 + 0x10;
>  
> -		xlr_resource_init(&xlr_net1_res[mac * 2],
> -				xlr_gmac_offsets[mac + 4],
> -				xlr_gmac_irqs[mac + 4]);
> +		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);

More typical is to avoid exceeding 80 columns
and wrap this line like:

		xlr_resource_init(&xlr_net1_res[mac * 2],
				  xlr_gmac_offsets[mac + 4],
				  xlr_gmac_irqs[mac + 4]);

Indenting the 2nd and 3rd lines with 4 tabs and 2 spaces
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux