On Wednesday, March 16, 2016 3:22 AM, Ian Abbott wrote: > On 15/03/16 21:48, H Hartley Sweeten wrote: >> Memory mapped io (dev->mmio) should not also be writing to the ioport >> (dev->iobase) registers. Add the missing 'else' to these functions. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/comedi/drivers/ni_mio_common.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > > Please add: > > Fixes: 0953ee4acca0 ("staging: comedi: ni_mio_common: checkpatch.pl > cleanup (else not useful)") > Cc: <stable@xxxxxxxxxxxxxxx> # 3.17+ > > Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> Ugh... Looks like I broke it. Greg, Would you like me to repost this with the Fixes/Cc added or do you got it? Thanks, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel