Re: [PATCH] staging: most: hdm-dim2: Remove possible dereference error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2016 at 06:32:15PM +0530, Amitoj Kaur Chawla wrote:
> Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
> with devm_request_irq") introduced the following static checker
> warning:
> drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
> error: 'dev->netinfo_task' dereferencing possible ERR_PTR()
> 
> Remove the warning by returning PTR_ERR immediately rather than 
> storing in a variable and returning at the end of the function
> since we do not need to free anything.
This patch is not about a warning.

This patch fixes the bug introduced in the previous patch that has
changed the control flow so that the error code returned by the
kthread_run was overwritten by the "ret = dim2_sysfs_probe" below.

regards
andy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux