Re: [PATCH] staging:vt6655: fix coding style violations for lines over 80 characters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Mar 15, 2016 at 01:49:24PM -0700, Kathryn Hampton wrote:
> I think I need to rebase and try again. Can someone please explain 
> the protocol for sending out the same patch?

In practice it depends on the maintainer but in general the right thing to do is
to indicate the patch version in the subject like this:

  [PATCHv2] staging: vt6655: fix coding style violations for lines over 80 characters

(Note also that I added a space after "staging:" which is the normal convention
for patch subjects.)

Then you ought to also explain in the message body why you needed to resend i.e.
what you changed in this version of the patch.  You should do this *after* the
"---" line following your sign off and *above* the diffstat if there is one.
This portion of the message body will not be included in the git log message so
it is a good place for development process discussion (as opposed to discussion
of the content of the patch itself).

In some cases maintainers will not expect all of this 100% but the above is the
generally preferred way to resubmit.  You may note that there are also a few
other conventions floating around.  Oh well, at least things aren't boring. ;)

> When I do this again, can I use the same description? It really does fit the
> changes made.

If the description matches the content of the patch and you have not been asked
to change it then you can leave it unchanged.

Hope this helps.

Thanks,
Forest
-- 
Forest Bond
http://www.forestbond.com/
http://www.rapidrollout.com/
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux