Re: [PATCH V2 1/9] staging: rtl8192u: check return value of read_nic_word_E

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Salah,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.5 next-20160311]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Salah-Triki/staging-rtl8192u-Checking-return-value-propagating-errors/20160314-115621
config: i386-randconfig-c0-03141212 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8192u/r8180_93cx6.c: In function 'eprom_read':
>> drivers/staging/rtl8192u/r8180_93cx6.c:159:7: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ret |= (eprom_r(dev) << (15 - i));
          ^

vim +/ret +159 drivers/staging/rtl8192u/r8180_93cx6.c

8fc8598e Jerry Chuang   2009-11-03  143  	eprom_cs(dev, 1);
8fc8598e Jerry Chuang   2009-11-03  144  	eprom_ck_cycle(dev);
8fc8598e Jerry Chuang   2009-11-03  145  	eprom_send_bits_string(dev, read_cmd, 3);
8fc8598e Jerry Chuang   2009-11-03  146  	eprom_send_bits_string(dev, addr_str, addr_len);
8fc8598e Jerry Chuang   2009-11-03  147  
2ad99c50 Sanjeev Sharma 2014-07-31  148  	/*
2ad99c50 Sanjeev Sharma 2014-07-31  149  	 * keep chip pin D to low state while reading.
2ad99c50 Sanjeev Sharma 2014-07-31  150  	 * I'm unsure if it is necessary, but anyway shouldn't hurt
2ad99c50 Sanjeev Sharma 2014-07-31  151  	 */
8fc8598e Jerry Chuang   2009-11-03  152  	eprom_w(dev, 0);
8fc8598e Jerry Chuang   2009-11-03  153  
8fc8598e Jerry Chuang   2009-11-03  154  	for (i = 0; i < 16; i++) {
2ad99c50 Sanjeev Sharma 2014-07-31  155  		/* eeprom needs a clk cycle between writing opcode&adr
2ad99c50 Sanjeev Sharma 2014-07-31  156  		 * and reading data. (eeprom outs a dummy 0)
2ad99c50 Sanjeev Sharma 2014-07-31  157  		 */
8fc8598e Jerry Chuang   2009-11-03  158  		eprom_ck_cycle(dev);
8fc8598e Jerry Chuang   2009-11-03 @159  		ret |= (eprom_r(dev) << (15 - i));
8fc8598e Jerry Chuang   2009-11-03  160  	}
8fc8598e Jerry Chuang   2009-11-03  161  
8fc8598e Jerry Chuang   2009-11-03  162  	eprom_cs(dev, 0);
8fc8598e Jerry Chuang   2009-11-03  163  	eprom_ck_cycle(dev);
8fc8598e Jerry Chuang   2009-11-03  164  
2ad99c50 Sanjeev Sharma 2014-07-31  165  	/* disable EPROM programming */
8fc8598e Jerry Chuang   2009-11-03  166  	write_nic_byte_E(dev, EPROM_CMD,
8fc8598e Jerry Chuang   2009-11-03  167  		       (EPROM_CMD_NORMAL<<EPROM_CMD_OPERATING_MODE_SHIFT));

:::::: The code at line 159 was first introduced by commit
:::::: 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 Staging: Added Realtek rtl8192u driver to staging

:::::: TO: Jerry Chuang <jerry-chuang@xxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux