Goto label was ambiguous change to out_free_page to signify that we will always go through the path even on success. Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx> Signed-off-by: Timothy Sell <timothy.sell@xxxxxxxxxx> --- drivers/staging/unisys/visorbus/visorchannel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c index ba26b54..b68a904 100644 --- a/drivers/staging/unisys/visorbus/visorchannel.c +++ b/drivers/staging/unisys/visorbus/visorchannel.c @@ -293,14 +293,14 @@ visorchannel_clear(struct visorchannel *channel, ulong offset, u8 ch, err = visorchannel_write(channel, offset + written, buf, thisbytes); if (err) - goto cleanup; + goto out_free_page; written += thisbytes; nbytes -= thisbytes; } err = 0; -cleanup: +out_free_page: free_page((unsigned long)buf); return err; } -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel