Hi Greg, Allow me to chip in as well. On 3 March 2016 at 16:17, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: >> From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> >> >> Play safe and add flags member to all structs. So we don't need to >> break API or create new IOCTL in the future if new features that requires >> flags arises. >> >> v2: check if flags are valid (zero, in this case) >> >> v3: return -EINVAL if flags are not zero'ed >> >> v4: add padding for 64-bit alignment >> >> v5: rebase to use only stacked sync_file_info > > Why are these vX things here in the changelog? > > And you just broke all existing userspace users of this code, why are > you allowed to do that? > In all honesty, isn't 'fluid ABI' one of the reasons behind staging ? That is how it was used by a few drivers in the past, at least. If the rules have changed and/or Android is special in that regard, we ought to make it perfectly clear so that people are aware from day 1. That aside, Android developers were clear that only internal, downstream components are using this code and they are OK with breaking the ABI [1]. Gustavo is in the process of rewriting their tests for upstream inclusion and he'll also update the Android side of things [2]. With those in mind, I think everything should be safe here. If you prefer to avoid the ABI break, which approach are you keen on - reassign new ioctl numbers (Rob suggestion) or use new header fence2.h (Daniel). Thank you Emil [1] https://lists.freedesktop.org/archives/dri-devel/2016-January/099592.html [2] https://lists.freedesktop.org/archives/dri-devel/2016-January/099726.html _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
