Re: [PATCH] staging: rtl8192u: check return value of read_nic_word_E

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Salah,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.5-rc6 next-20160303]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Salah-Triki/staging-rtl8192u-check-return-value-of-read_nic_word_E/20160304-093832
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8192u/r8192U_core.c: In function 'rtl8192_read_eeprom_info':
>> drivers/staging/rtl8192u/r8192U_core.c:2496:8: warning: unused variable 'tmp' [-Wunused-variable]
       u16 tmp = 0;
           ^
   drivers/staging/rtl8192u/r8192U_core.c:2707:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +/tmp +2496 drivers/staging/rtl8192u/r8192U_core.c

8fc8598e Jerry Chuang     2009-11-03  2480  		priv->eeprom_vid = 0;
8fc8598e Jerry Chuang     2009-11-03  2481  		priv->eeprom_pid = 0;
8fc8598e Jerry Chuang     2009-11-03  2482  		priv->card_8192_version = VERSION_819xU_B;
8fc8598e Jerry Chuang     2009-11-03  2483  		priv->eeprom_ChannelPlan = 0;
8fc8598e Jerry Chuang     2009-11-03  2484  		priv->eeprom_CustomerID = 0;
8fc8598e Jerry Chuang     2009-11-03  2485  	}
069b3162 Raphaël Beamonte 2015-09-20  2486  	RT_TRACE(COMP_EPROM,
069b3162 Raphaël Beamonte 2015-09-20  2487  		 "vid:0x%4x, pid:0x%4x, CustomID:0x%2x, ChanPlan:0x%x\n",
069b3162 Raphaël Beamonte 2015-09-20  2488  		 priv->eeprom_vid, priv->eeprom_pid, priv->eeprom_CustomerID,
069b3162 Raphaël Beamonte 2015-09-20  2489  		 priv->eeprom_ChannelPlan);
14285c1f Raphaël Beamonte 2015-08-18  2490  	/* set channelplan from eeprom */
8fc8598e Jerry Chuang     2009-11-03  2491  	priv->ChannelPlan = priv->eeprom_ChannelPlan;
2716141c Xenia Ragiadakou 2013-06-03  2492  	if (bLoad_From_EEPOM) {
8fc8598e Jerry Chuang     2009-11-03  2493  		int i;
7b25c24e Raphaël Beamonte 2015-08-18  2494  
2716141c Xenia Ragiadakou 2013-06-03  2495  		for (i = 0; i < 6; i += 2) {
8fc8598e Jerry Chuang     2009-11-03 @2496  			u16 tmp = 0;
7b25c24e Raphaël Beamonte 2015-08-18  2497  
f32e9126 Salah Triki      2016-03-03  2498  			ret = eprom_read(dev, (u16)((EEPROM_NODE_ADDRESS_BYTE_0 + i) >> 1));
f32e9126 Salah Triki      2016-03-03  2499  			if (ret)
f32e9126 Salah Triki      2016-03-03  2500  				return ret;
f32e9126 Salah Triki      2016-03-03  2501  			*(u16 *)(&dev->dev_addr[i]) = (u16) ret;
8fc8598e Jerry Chuang     2009-11-03  2502  		}
2716141c Xenia Ragiadakou 2013-06-03  2503  	} else {
8fc8598e Jerry Chuang     2009-11-03  2504  		memcpy(dev->dev_addr, bMac_Tmp_Addr, 6);

:::::: The code at line 2496 was first introduced by commit
:::::: 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 Staging: Added Realtek rtl8192u driver to staging

:::::: TO: Jerry Chuang <jerry-chuang@xxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux