RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, March 02, 2016 7:28 AM, Ian Abbott wrote:
> Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging:
> comedi: Prefer using the BIT macro"), but I replaced the use of the BIT
> macro with hexadecimal constants instead of the original left bit-shift
> expressions.  We shouldn't use the BIT macro in "comedi.h" as it is
> intended to be included in the UAPI headers.
>
> Patch 2 just fixes the kernel-doc comment for struct comedi_krange.
>
> 1) staging: comedi: comedi.h: Do not use BIT macro
> 2) staging: comedi: comedi.h: Fix comment for struct comedi_krange
>
>  drivers/staging/comedi/comedi.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Thanks for fixing this. I noticed the same issue yesterday.

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux