Hi, This is the fourth (and final) set of patches that aim to replace custom defines for register fields. The MSB:LSB notation for register fields is completely removed and replaced by BIT() for single-bit fields and with *_MASK for multi-bit fields. The removal of MSB:LSB notation allowed to get rid of FIELD_*() macros. Mike Rapoport (5): staging: sm750fb: use BIT() macro for single-bit fields definition staging: sm750: change definition of multi-bit register fields staging: sm750fb: replace absDiff with kernel standard abs macro staging: sm750fb: move MHz() and roundedDiv() close to their usage staging: sm750fb: remove sm750_help.h drivers/staging/sm750fb/ddk750_chip.c | 7 +- drivers/staging/sm750fb/ddk750_help.h | 1 - drivers/staging/sm750fb/ddk750_reg.h | 1978 ++++++++++++-------------------- drivers/staging/sm750fb/sm750_accel.c | 1 - drivers/staging/sm750fb/sm750_accel.h | 98 +- drivers/staging/sm750fb/sm750_cursor.c | 1 - drivers/staging/sm750fb/sm750_help.h | 56 - 7 files changed, 780 insertions(+), 1362 deletions(-) delete mode 100644 drivers/staging/sm750fb/sm750_help.h -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel