On Fri, Feb 19, 2016 at 05:37:10PM +0900, Leo Kim wrote:
> This patch removes unnecessary wilc_debug print log.
> The print log was written when if condition fail.
> The condition is chip-id check function.
> Also, replaces this condition with normal function.
>
> Signed-off-by: Leo Kim <leo.kim@xxxxxxxxx>
> ---
> drivers/staging/wilc1000/wilc_wlan.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index a51c66b..4873106 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -508,9 +508,7 @@ void chip_wakeup(struct wilc *wilc)
>
> do {
> usleep_range(2 * 1000, 2 * 1000);
> - if ((wilc_get_chipid(wilc, true) == 0))
> - wilc_debug(N_ERR, "Couldn't read chip id. Wake up failed\n");
> -
> + wilc_get_chipid(wilc, true);
Why do we need this function when we call it again on the next line?
> } while ((wilc_get_chipid(wilc, true) == 0) && ((++trials % 3) == 0));
^^^^^^^^^^^^^^^
Also what the heck is ((++trials % 3) == 0))??? It looks like we are
supposed to retry 3 times but actually we don't retry at all. :P
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
