On Wed, Feb 17, 2016 at 12:55:47AM +0530, Shraddha Barke wrote:
> Replace the usage of BUG_ON with WARN_ON.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@xxxxxxxxx>
> ---
> drivers/staging/gdm72xx/gdm_wimax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c
> index 2fa86ad..8861750 100644
> --- a/drivers/staging/gdm72xx/gdm_wimax.c
> +++ b/drivers/staging/gdm72xx/gdm_wimax.c
> @@ -100,7 +100,7 @@ static struct evt_entry *get_event_entry(void)
>
> static void put_event_entry(struct evt_entry *e)
> {
> - BUG_ON(!e);
> + WARN_ON(!e);
>
> list_add_tail(&e->list, &wm_event.freeq);
You may was well delete the check. There is only one caller so we know
e is not NULL. It's going to oops on the next line anyway and that
would give us a pretty decent stack trace.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
