On 02/08/2016 07:48 AM, Bhumika Goyal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
>
> This was done with coccinelle:
>
> @@ int g; @@
>
> -(1 << g)
> +BIT(g)
>
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
Hi,
Thanks for the patch. This looks good.
> ---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 0c73bce..ccf3157 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -117,7 +117,7 @@
> */
> #define POLYNOM 0x2F
> #define POLYNOM_ORDER 8
> -#define HIGHBIT (1 << (POLYNOM_ORDER - 1))
> +#define HIGHBIT BIT((POLYNOM_ORDER - 1))
But please drop the extra brackets and resend the patch.
>
> struct ad7280_state {
> struct spi_device *spi;
> @@ -388,7 +388,7 @@ static ssize_t ad7280_show_balance_sw(struct device *dev,
>
> return sprintf(buf, "%d\n",
> !!(st->cb_mask[this_attr->address >> 8] &
> - (1 << ((this_attr->address & 0xFF) + 2))));
> + BIT(((this_attr->address & 0xFF) + 2))));
Same here.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
