On Sat, Feb 06, 2016 at 08:53:57AM -0600, Larry Finger wrote: > On 02/06/2016 08:41 AM, Pinkesh Badjatiya wrote: > >Fix Comparisons with constant on the left side of the test. > >Checkpatch.pl warning. > >-- > >WARNING: Comparisons should place the constant on the right side of the > >test > >296: FILE: ./rtl8712_cmd.c:296: > > while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) && > > > >Signed-off-by: Pinkesh Badjatiya <pinkeshbadjatiya@xxxxxxxxx> > >--- > > drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This is another case where the writers of checkpatch are forcing their ideas > of style on the whole world. The problem is that if I reject your patch, it > will be submitted by someone else. Thus, reluctantly > > Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> Well, the general kernel coding style is to put constants on the right hand of the expression, so it is good to have it this way... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
