On Fri, Dec 11, 2015 at 04:39:26PM -0500, Benjamin Young wrote: > Fixed coding style for null comparisons in goldfish_audio.c to be more consistant > with the rest of the kernel coding style > > Signed-off-by: Benjamin Young <youngcdev@xxxxxxxxx> > --- > drivers/staging/goldfish/goldfish_audio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c > index f1e1838..364fdcd 100644 > --- a/drivers/staging/goldfish/goldfish_audio.c > +++ b/drivers/staging/goldfish/goldfish_audio.c > @@ -280,12 +280,12 @@ static int goldfish_audio_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, data); > > r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (r == NULL) { > + if (!r) { > dev_err(&pdev->dev, "platform_get_resource failed\n"); > return -ENODEV; > } > data->reg_base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE); > - if (data->reg_base == NULL) > + if (!data->reg_base) > return -ENOMEM; > > data->irq = platform_get_irq(pdev, 0); > @@ -295,7 +295,7 @@ static int goldfish_audio_probe(struct platform_device *pdev) > } > data->buffer_virt = dmam_alloc_coherent(&pdev->dev, > COMBINED_BUFFER_SIZE, &buf_addr, GFP_KERNEL); > - if (data->buffer_virt == NULL) { > + if (!data->buffer_virt) { > dev_err(&pdev->dev, "allocate buffer failed\n"); > return -ENOMEM; > } Same here, someone beat you to it. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel