Re: [PATCH] android/binder: fix fput comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 25, 2015 at 09:47:17PM +0100, Jann Horn wrote:
> Just something I noticed while looking at FD-passing code.
> Didn't test the change.
> 
> BUG_ON is intentional, if someone rewrites the code to hit
> that, it can be a security issue.

Never add BUG to the kernel, you just crashed the machine and made it so
that the user lost their data without any idea of what happend :(

and if at all possible, please test your changes before sending them
out...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux