Hi Leo,
On Tue, Feb 2, 2016 at 11:02 PM, Leo Kim <leo.kim@xxxxxxxxx> wrote:
> This patch removes function wilc_dealloc_assoc_resp_info()'.
> Does not need this function which only free memory.
> Therefore, this function is removed and changed directly with kfree.
>
> Signed-off-by: Leo Kim <leo.kim@xxxxxxxxx>
Nice work!
Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 22 ----------------------
> drivers/staging/wilc1000/coreconfigurator.h | 1 -
> drivers/staging/wilc1000/host_interface.c | 4 ++--
> 3 files changed, 2 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 81dd22e..c86278d 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -386,25 +386,3 @@ s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
>
> return 0;
> }
> -
> -s32 wilc_dealloc_assoc_resp_info(tstrConnectRespInfo *connect_resp_info)
> -{
> - s32 result = 0;
> -
> - if (connect_resp_info) {
> - if (connect_resp_info->pu8RespIEs) {
> - kfree(connect_resp_info->pu8RespIEs);
> - connect_resp_info->pu8RespIEs = NULL;
> - } else {
> - result = -EFAULT;
> - }
> -
> - kfree(connect_resp_info);
> - connect_resp_info = NULL;
> -
> - } else {
> - result = -EFAULT;
> - }
> -
> - return result;
> -}
> diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h
> index 23775e4..d42f47c 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.h
> +++ b/drivers/staging/wilc1000/coreconfigurator.h
> @@ -123,7 +123,6 @@ typedef struct {
> s32 wilc_parse_network_info(u8 *msg_buffer, tstrNetworkInfo **ret_network_info);
> s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
> tstrConnectRespInfo **ret_connect_resp_info);
> -s32 wilc_dealloc_assoc_resp_info(tstrConnectRespInfo *connect_resp_info);
> void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
> u32 u32Length);
> void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 3ce3a7c..15c266b 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -1505,8 +1505,8 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
> }
>
> if (pstrConnectRespInfo) {
> - wilc_dealloc_assoc_resp_info(pstrConnectRespInfo);
> - pstrConnectRespInfo = NULL;
> + kfree(pstrConnectRespInfo->pu8RespIEs);
> + kfree(pstrConnectRespInfo);
> }
> }
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
