On Tue, 2016-02-02 at 22:28 +0100, Colin Vidal wrote: > On Tue, 2016-02-02 at 13:14 -0800, Joe Perches wrote: > > On Tue, 2016-02-02 at 21:57 +0100, Colin Vidal wrote: > > > Set constant on the left of the test, and jump a new line to avoid to > > > exceed the 80 char length limit. > > [] > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c [] > > bool rtw_IOL_applied(struct adapter *adapter) > > { > > return adapter->registrypriv.fw_iol == 1 || > > (adapter->registrypriv.fw_iol == 2 && > > !adapter_to_dvobj(adapter)->ishighspeed); > > } > > > > Oh, yeah, the second one is obviously finer. If I'm right, I should > resend a new patch with a subject which looks something like "[PATCH > v2] ... " ? correct. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel