On Sat, Jan 30, 2016 at 12:52:45PM -0800, Santosh Madiraju wrote:
> From: madiraju <madiraju.santosh@xxxxxxxxx>
You do not need this extra From: line here. Even if you need to give it
for some reason then the name should match the name as given in your
Signed-off-by: name.
>
> Removed unnecessary spaces to match coding style.
>
> Signed-off-by: Santosh Madiraju <madiraju.santosh@xxxxxxxxx>
^
Did you write this Signed-off-by: manually? There is an extra space
there, i have marked, which will not be there if git creates the
Signed-off-by.
> ---
> drivers/staging/xgifb/XGI_main_26.c | 22 ++++++----------------
> 1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 89f5b55..4978737 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1989,7 +1989,6 @@ static int xgifb_probe(struct pci_dev *pdev,
> &fb_info->var.vsync_len,
> &fb_info->var.sync,
> &fb_info->var.vmode)) {
> -
> if ((fb_info->var.vmode & FB_VMODE_MASK) ==
> FB_VMODE_INTERLACED) {
> fb_info->var.yres <<= 1;
> @@ -1999,10 +1998,7 @@ static int xgifb_probe(struct pci_dev *pdev,
> fb_info->var.pixclock >>= 1;
> fb_info->var.yres >>= 1;
> fb_info->var.yres_virtual >>= 1;
> - }
> -
> - }
> -
> + } }
:(
This does not match coding style.
BTW, what error checkpatch showed here? I am not finding anythig here
except an extra blank line.
> fb_info->flags = FBINFO_FLAG_DEFAULT;
> fb_info->screen_base = xgifb_info->video_vbase;
> fb_info->fbops = &XGIfb_ops;
> @@ -2064,33 +2060,27 @@ static struct pci_driver xgifb_driver = {
> .remove = xgifb_remove
> };
>
> -
> -
> /*****************************************************/
> /* MODULE */
> /*****************************************************/
>
> module_param(mode, charp, 0);
> -MODULE_PARM_DESC(mode,
> - "Selects the desired default display mode in the format XxYxDepth (eg. 1024x768x16).");
> +MODULE_PARM_DESC(mode, "Selects the desired default display mode in the format XxYxDepth (eg. 1024x768x16).");
>
> module_param(forcecrt2type, charp, 0);
> -MODULE_PARM_DESC(forcecrt2type,
> - "Force the second display output type. Possible values are NONE, LCD, TV, VGA, SVIDEO or COMPOSITE.");
> +MODULE_PARM_DESC(forcecrt2type, "Force the second display output type. Possible values are NONE, LCD, TV, VGA, SVIDEO or COMPOSITE.");
>
> module_param(vesa, int, 0);
> -MODULE_PARM_DESC(vesa,
> - "Selects the desired default display mode by VESA mode number (eg. 0x117).");
> +MODULE_PARM_DESC(vesa, "Selects the desired default display mode by VESA mode number (eg. 0x117).");
>
> module_param(filter, int, 0);
> -MODULE_PARM_DESC(filter,
> - "Selects TV flicker filter type (only for systems with a SiS301 video bridge). Possible values 0-7. Default: [no filter]).");
> +MODULE_PARM_DESC(filter, "Selects TV flicker filter type (only for systems with a SiS301 video bridge). Possible values 0-7. Default: [no filter]).");
>
> static int __init xgifb_init(void)
> {
> char *option = NULL;
>
> - if (forcecrt2type != NULL)
> + if (!forcecrt2type)
oops...
shouldn't it be:
if (forcecrt2type)
regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
