Re: [PATCH] add fbtft ssd1325 controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Same stuff.  Run checkpatch.pl.

> +	gpio_set_value(par->gpio.dc, 1);
> +	/* Write data */
> +
> +	ret =
> +		par->fbtftops.write(par, par->txbuf.buf,
> +				par->info->var.xres * par->info->var.yres / 2);

Clean that line.

> +static struct fbtft_display display = {
> +	.regwidth = 8,
> +	.width = WIDTH,
> +	.height = HEIGHT,
> +	.txbuflen = WIDTH * HEIGHT / 2,

The other driver didn't have a txbuflen.  What does that do?  (I have
barely looked at fbtft before so I don't know).

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux