Thank you for your comment.
I'll resend again this patch after considering your suggestion.
regards
Chaehyun Lim
On Tue, Jan 12, 2016 at 10:00 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Tue, 2016-01-12 at 09:32 +0900, Chaehyun Lim wrote:
>> This patch removes typedef from struct wilc_cfg_byte_t and renames it to
>> wilc_cfg_byte.
>
> Is this really a good name?
>
>> diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.h b/drivers/staging/wilc1000/wilc_wlan_cfg.h
> []
>> @@ -10,10 +10,10 @@
>> #ifndef WILC_WLAN_CFG_H
>> #define WILC_WLAN_CFG_H
>>
>> -typedef struct {
>> +struct wilc_cfg_byte {
>> u16 id;
>> u16 val;
>> -} wilc_cfg_byte_t;
>> +};
>
> val is a u16, calling it cfg_byte seems misleading.
>
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
