On 12/01/16 12:07, Dan Carpenter wrote:
None of these have a change description. How does using CR_CHAN() help? Does it fix a bug? What are the user visible effects of the bug? (I could figure this out myself, but you'd still have to resend with the information so I haven't). regards, dan carpenter
Yes, it could do with a change description. It doesn't fix a bug as NISTC_AI_MODE1_CONVERT_SRC() already masks the value sufficiently, but using CR_CHAN() here makes the code clearer as it avoids passing some irrelevant bits to NISTC_AI_MODE1_CONVERT_SRC() in the first place.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
