Re: [PATCH 5/7] staging/wilc1000: Remove unneeded imports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 10, 2016 at 09:13:20PM +0100, Janosch Frank wrote:
> Am 10.01.2016 um 20:30 schrieb kbuild test robot:
> >Hi Janosch,
> >
> >[auto build test ERROR on v4.4-rc8]
> >[cannot apply to staging/staging-testing next-20160108]
> >[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> >
> >url:    https://github.com/0day-ci/linux/commits/Janosch-Frank/staging-wilc1000-Refactor-spi-read-and-write-functions/20160111-022042
> >config: x86_64-randconfig-s0-01110305 (attached as .config)
> >reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64
> >
> >All error/warnings (new ones prefixed by >>):
> >
> >>>drivers/staging/wilc1000/linux_wlan_spi.c:60:1: warning: data definition has no type or storage class
> >     MODULE_DEVICE_TABLE(of, wilc1000_of_match);
> >     ^
> >>>drivers/staging/wilc1000/linux_wlan_spi.c:60:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> >>>drivers/staging/wilc1000/linux_wlan_spi.c:60:1: warning: parameter names (without types) in function declaration
> >    cc1: some warnings being treated as errors
> >
> >vim +60 drivers/staging/wilc1000/linux_wlan_spi.c
> >
> >c5c77ba1 Johnny Kim 2015-05-11  54
> >c5c77ba1 Johnny Kim 2015-05-11  55  #ifdef CONFIG_OF
> >c5c77ba1 Johnny Kim 2015-05-11  56  static const struct of_device_id wilc1000_of_match[] = {
> >c5c77ba1 Johnny Kim 2015-05-11  57  	{ .compatible = "atmel,wilc_spi", },
> >c5c77ba1 Johnny Kim 2015-05-11  58  	{}
> >c5c77ba1 Johnny Kim 2015-05-11  59  };
> >c5c77ba1 Johnny Kim 2015-05-11 @60  MODULE_DEVICE_TABLE(of, wilc1000_of_match);
> >c5c77ba1 Johnny Kim 2015-05-11  61  #endif
> >c5c77ba1 Johnny Kim 2015-05-11  62
> >c5c77ba1 Johnny Kim 2015-05-11  63  struct spi_driver wilc_bus __refdata = {
> >
> >:::::: The code at line 60 was first introduced by commit
> >:::::: c5c77ba18ea66aa05441c71e38473efb787705a4 staging: wilc1000: Add SDIO/SPI 802.11 driver
> >
> >:::::: TO: Johnny Kim <johnny.kim@xxxxxxxxx>
> >:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >
> >---
> >0-DAY kernel test infrastructure                Open Source Technology Center
> >https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> >
> >
> module.h should not have been removed, as it contains the
> macro. With the right .config I would have noticed that...
> 
> Is a v2 needed/wanted?

It is needed.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux