>>>2. Is it OK to hardcode the appropriate gfp_t flags for the >>>IOC_LIBCFS_MEMHOG, as the userspace >>>seems to be taking the decision about the page allocation >>>zone/strategy, is this what is intended? >> >> The memhog functionality is used to introduce memory pressure on a client >> or server during operation to test error handling as well as memory >> allocation deadlocks (e.g. GFP_KERNEL used where GFP_NOFS should be used). >> There are other ways to do this in the kernel today, so all of the memhog >> code could just be deleted I think. >> >> This looks like kportal_memhog_alloc(), kportal_memhog_free(), >> IOC_LIBCFS_MEMHOG, and struct libcfs_device_userstate could be removed. >> >> >> Cheers, Andreas >> >Thanks Andreas, I will send out a separate patch with the cleanup as >you suggested. I missed this email. I just sent the cleanup patches a bit ago. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
